[U-Boot] [PATCH v2 5/7] ext2: Cache line aligned partial sector bounce buffer

Wolfgang Denk wd at denx.de
Thu Oct 6 20:45:20 CEST 2011


Dear Anton Staaf,

In message <1317763491-7274-6-git-send-email-robotboy at chromium.org> you wrote:
> Currently, if a device read request is done that does not begin or end
> on a sector boundary a stack allocated bounce buffer is used to perform
> the read, and then just the part of the sector that is needed is copied
> into the users buffer.  This stack allocation can mean that the bounce
> buffer will not be aligned to the dcache line size.  This is a problem
> when caches are enabled because unaligned cache invalidates are not
> safe.
> 
> This patch uses ALLOC_CACHE_ALIGN_BUFFER to create a stack allocated
> cache line size aligned bounce buffer.
> 
> Signed-off-by: Anton Staaf <robotboy at chromium.org>
> Acked-by: Mike Frysinger <vapier at gentoo.org>
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> Cc: Mike Frysinger <vapier at gentoo.org>
> Cc: Dave Liu <r63238 at freescale.com>
> Cc: Andy Fleming <afleming at gmail.com>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> 
> ---
>  fs/ext2/dev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A weak mind is like a microscope, which magnifies trifling things,
but cannot receive great ones.      -- Philip Earl of Chesterfield


More information about the U-Boot mailing list