[U-Boot] [PATCH 1/1] add support for Sysam AMCORE board

Wolfgang Denk wd at denx.de
Thu Oct 6 22:39:09 CEST 2011


Dear Angelo Dureghello,

In message <4E882617.2070208 at gmail.com> you wrote:
> Add support for mcf5307 based "Sysam AMCORE" open board.
> Board main features:
>    cpu : Freescale mcf5307
>  flash : 4MB, nor, SST39VF3201B
>  sdram : 16M, MT48LC4M32B2
>    eth : 1 x dm9000e
>    rtc : ds1338, i2c
> 
> Signed-off-by: Angelo Dureghello <sysamfw at gmail.com>
> ---
> 
>  Makefile                      |    3 +
>  board/sysam/amcore/Makefile   |   43 ++++
>  board/sysam/amcore/amcore.c   |  174 ++++++++++++++++
>  board/sysam/amcore/config.mk  |   23 ++
>  board/sysam/amcore/flash.c    |  462 +++++++++++++++++++++++++++++++++++++++++
>  board/sysam/amcore/u-boot.lds |   99 +++++++++
>  boards.cfg                    |    1 +
>  include/configs/amcore.h      |  193 +++++++++++++++++
>  include/flash.h               |    1 +
>  9 files changed, 999 insertions(+), 0 deletions(-)

Entry to MAINTAINERS missing, entry to boards.cgf missing.

> diff --git a/Makefile b/Makefile
> index 77140eb..7b56c09 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -608,6 +608,9 @@ ucname	= $(shell echo $(1) | sed -e 's/\(.*\)_config/\U\1/')
>  ## Coldfire
>  #########################################################################
>  
> +amcore_config:
> +	@$(MKCONFIG) -n $@ -a amcore m68k mcf530x amcore sysam
> +

We don't add boards to Makefile any more.

checkpatch says: total: 79 errors, 65 warnings, 1017 lines checked

Please fix and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are only young once, but you can stay immature indefinitely.


More information about the U-Boot mailing list