[U-Boot] [PATCH v4 01/19] sandbox: Add architecture header files

[Simon Glass]

Hi Wolfgang,

On Thu, Oct 6, 2011 at 2:11 PM, Wolfgang Denk <wd at denx.de> wrote:

> Dear Simon Glass,
>
> In message <1317706010-17151-2-git-send-email-sjg at chromium.org> you wrote:
> > This adds required header files for the sandbox architecture, and a basic
> > description of what sandbox is (README.sandbox).
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> > Changes in v2:
> > - Removed unneeded clock.h
> > - Moved gpio.h to asm-generic, removed GPIO_COUNT
> > - Removed kernel cruft from posix_types.h
> > - Removed dummy field from struct pt_regs
> > - Remove contents of string.h; instead include linux/string.h
> > - Remove unneeded functions in u-boot-sandbox.h
> > - Remove contents of unaligned.h; instead include asm-generic/unaligned.h
> >
> > Changes in v4:
> > - Remove mon_len from global data
> > - Fix up arm header file incorrectly removed
> > - Added README note that standalone/API support is not available
> >
> >  arch/sandbox/include/asm/bitops.h         |  162
> +++++++++++++++++++++++++++++
> >  arch/sandbox/include/asm/byteorder.h      |   40 +++++++
> >  arch/sandbox/include/asm/config.h         |   26 +++++
> >  arch/sandbox/include/asm/global_data.h    |   67 ++++++++++++
> >  arch/sandbox/include/asm/io.h             |   41 +++++++
> >  arch/sandbox/include/asm/posix_types.h    |   57 ++++++++++
> >  arch/sandbox/include/asm/ptrace.h         |   38 +++++++
> >  arch/sandbox/include/asm/string.h         |   23 ++++
> >  arch/sandbox/include/asm/system.h         |   36 +++++++
> >  arch/sandbox/include/asm/types.h          |   72 +++++++++++++
> >  arch/sandbox/include/asm/u-boot-sandbox.h |   38 +++++++
> >  arch/sandbox/include/asm/u-boot.h         |   61 +++++++++++
> >  arch/sandbox/include/asm/unaligned.h      |   23 ++++
> >  doc/README.sandbox                        |   49 +++++++++
> >  include/asm-generic/gpio.h                |   25 +++++
> >  include/common.h                          |    3 +
> >  16 files changed, 761 insertions(+), 0 deletions(-)
> >  create mode 100644 arch/sandbox/include/asm/bitops.h
> >  create mode 100644 arch/sandbox/include/asm/byteorder.h
> >  create mode 100644 arch/sandbox/include/asm/config.h
> >  create mode 100644 arch/sandbox/include/asm/global_data.h
> >  create mode 100644 arch/sandbox/include/asm/io.h
> >  create mode 100644 arch/sandbox/include/asm/posix_types.h
> >  create mode 100644 arch/sandbox/include/asm/ptrace.h
> >  create mode 100644 arch/sandbox/include/asm/string.h
> >  create mode 100644 arch/sandbox/include/asm/system.h
> >  create mode 100644 arch/sandbox/include/asm/types.h
> >  create mode 100644 arch/sandbox/include/asm/u-boot-sandbox.h
> >  create mode 100644 arch/sandbox/include/asm/u-boot.h
> >  create mode 100644 arch/sandbox/include/asm/unaligned.h
> >  create mode 100644 doc/README.sandbox
> >  create mode 100644 include/asm-generic/gpio.h
>
> Checkpatch says:
>
> total: 0 errors, 44 warnings, 767 lines checked
>

Yes there are a lot of warnings. Most of them seemed to be Linux-specific to
me (e.g. use linux/io.h instead of asm/io.h, or not adding new typedefs).
Should I post a list of them and why I think they are not relevant?

Regards,
Simon


>
> Please clean up and resubmit.  Thanks.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Unix: Some say the learning curve is steep,  but  you  only  have  to
> climb it once.                                      - Karl Lehenbauer
>