[U-Boot] [PATCH 1/4] macb: initial support for Cadence GEM

Wolfgang Denk wd at denx.de
Thu Oct 6 23:50:57 CEST 2011


Dear Dave Aldridge,

In message <1313674339-1834-2-git-send-email-fovsoft at gmail.com> you wrote:
> The Cadence GEM is based on the MACB Ethernet controller but has a few
> small changes with regards to register and bitfield placement.  This
> patch detects the presence of a GEM by reading the module ID register
> and setting a flag appropriately.
> 
> This handles the new HW address, USRIO and hash register base register
> locations in GEM.
> 
> Signed-off-by: Dave Aldridge <fovsoft at gmail.com>
> ---
>  drivers/net/macb.c |   18 +++++++++++-----
>  drivers/net/macb.h |   55 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+), 6 deletions(-)

Checkpatch says:

total: 2 errors, 1 warnings, 128 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No one wants war.
	-- Kirk, "Errand of Mercy", stardate 3201.7


More information about the U-Boot mailing list