[U-Boot] [PATCH 2/2] mpc85xx: support for Freescale COM Express P2020

[Ira W. Snyder]

On Thu, Oct 06, 2011 at 11:18:48PM +0200, Wolfgang Denk wrote:
> Dear "Ira W. Snyder",
> 
> In message <1317159046-11886-3-git-send-email-iws at ovro.caltech.edu> you wrote:
> > This adds support for the Freescale COM Express P2020 board. This board
> > is similar to the P1_P2_RDB, but has some extra (as well as missing)
> > peripherals.
> > 
> > Unlike all other mpc85xx boards, it uses a watchdog timeout to reset.
> > Using the HRESET_REQ register does not work.
> > 
> > Signed-off-by: Ira W. Snyder <iws at ovro.caltech.edu>
> > ---
> >  arch/powerpc/include/asm/immap_85xx.h |    1 +
> >  board/freescale/p2020come/Makefile    |   53 +++
> >  board/freescale/p2020come/ddr.c       |  245 +++++++++++++
> >  board/freescale/p2020come/law.c       |   36 ++
> >  board/freescale/p2020come/p2020come.c |  393 ++++++++++++++++++++
> >  board/freescale/p2020come/pci.c       |   43 +++
> >  board/freescale/p2020come/tlb.c       |   91 +++++
> >  boards.cfg                            |    3 +
> >  include/configs/P2020COME.h           |  638 +++++++++++++++++++++++++++++++++
> >  9 files changed, 1503 insertions(+), 0 deletions(-)
> >  create mode 100644 board/freescale/p2020come/Makefile
> >  create mode 100644 board/freescale/p2020come/ddr.c
> >  create mode 100644 board/freescale/p2020come/law.c
> >  create mode 100644 board/freescale/p2020come/p2020come.c
> >  create mode 100644 board/freescale/p2020come/pci.c
> >  create mode 100644 board/freescale/p2020come/tlb.c
> >  create mode 100644 include/configs/P2020COME.h
> 
> Checkpatch says:
> 
> total: 6 errors, 23 warnings, 1515 lines checked
> 
> Please clean up and resubmit.  Thanks.
> 

What version of checkpatch do you use? I get 6 errors, 27 warnings with
the checkpatch from Linux v3.1-rc9-12-g6367f17. I wonder if you have a
version specific for U-Boot which removes the Linux-specific warnings,
such as:

WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#137: FILE: board/freescale/p2020come/ddr.c:28:
+#include <asm/io.h>

Also, are we now enforcing strict 80 character limits in
include/configs? I ran this patch through checkpatch before sending it
to the mailing list. Everything it flagged is either an 80 char limit in
a configuration file, copied from the corresponding files in the
boards/freescale/p1_p2_rdb directory, or obviously Linux-specific.

Thanks,
Ira