[U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI

Marek Vasut marek.vasut at gmail.com
Fri Oct 7 01:30:14 CEST 2011


Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1316977676-10284-1-git-send-email-marek.vasut at gmail.com> you 
wrote:
> > Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> > Cc: Remy Bohmer <linux at bohmer.net>
> > ---
> > 
> >  drivers/usb/host/ehci-hcd.c |   33 ++++++++++++++++++++++++++++++++-
> >  1 files changed, 32 insertions(+), 1 deletions(-)
> > 
> > V2: Drop redundant bogus header.
> 
> Checkpatch says:
> 
> total: 0 errors, 1 warnings, 43 lines checked
> 
> Please clean up and resubmit.  Thanks.
> 
> Best regards,
> 
> Wolfgang Denk

The extern-stuff checkpatch is complaining about is a problem with usbkbd.c . 
The file needs cleanup, badly, only then we can get rid of those externs.

I'd prefer to get this applied and then cleanup the usbkbd.c. The musb driver 
suffers the same trouble, so it can be cleaned up with this together.

Cheers


More information about the U-Boot mailing list