[U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP

Marek Vasut marek.vasut at gmail.com
Fri Oct 7 01:31:53 CEST 2011


Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1316977237-8709-1-git-send-email-marek.vasut at gmail.com> you wrote:
> > This allows the keyboard to avoid requests via Interrupt Endpoint
> > altogether and run all requests via Control Endpoint. This uses the
> > Get_Report request.
> > 
> > Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> > Cc: Remy Bohmer <linux at bohmer.net>
> > ---
> > 
> >  common/usb_kbd.c |   64
> >  ++++++++++++++++++++++++++++++++++++++++++----------- 1 files changed,
> >  50 insertions(+), 14 deletions(-)
> > 
> > V2: Add missing condition to ignore repetitive events when polling via
> > EP0
> 
> Checkpatch says:
> 
> total: 5 errors, 1 warnings, 97 lines checked
> 
> Please clean up and resubmit.  Thanks.
> 
> Best regards,
> 
> Wolfgang Denk

Please see my previous comment about the state of usbkbd.c. The warnings are 
from original code that was moved around.

I'd prefer to submit further usbkbd cleanup patch.

Cheers


More information about the U-Boot mailing list