[U-Boot] [PATCH v15 1/9] nds32: add header files support for nds32

[Wolfgang Denk]

Dear =?UTF-8?B?6aas5YWL5rOh?=,

In message <CACCg+XM0r0z0Xm1C9zu9Zc4bJ+sX5b2Gv3w_v5eBjOVX9AsTbA at mail.gmail.com> you wrote:
> 
> I believe you must be exhausted for reviewing these patches again and again.

Not yet - actually I'm playing with doing such things in a mostly
automated way.

> However, we've discussed before, to support a new architecture, there
> are some definitions
> and codes which the checkpatch rules cannot be adapted.

First, we can adapt chackpatch rules.  It just needs to be done.

> We've also discussed that Linux documents said checkpatch is just a
> reference rule,

I'dlike to see checkpatch customized for our needs.  The tools to do
that are in place now.

> you still need to have human examination.

Indeed.

> I guess you just forget that because the patch "works" is too heavy
> and patch check
> automation didn't help on special case much.

I manually inspected all output before actually sending any messages
out.

> When we discuss about those was about NDS32 patch v7, and now is patch v15.
> We've to a lot of fix, includes relocation.
>
> So, could you please tell me now, should I resend the patch v16 or you
> still have my v15
> patches and kindly tell me which part need to be fixed? Thanks!

There is a large number of WARNING: Use of volatile is usually wrong;
I think you bit macros and I/O accessors should be cleaned up. I don;t
want to see volatile there.

WARNING: line over 80 characters needs to be fixed, obviously.


> The 8 errors is due to the new assembly march.h added.
> Only 2 new cases introduced.
>
> ERROR: space prohibited before open square bracket '['
> #1032: FILE: arch/nds32/include/asm/macro.h:66:
> +       lwi     $r5, [$r4]
> This is to load a 32bit from the address x, while the value of
> address x is stored in $r4, and load it into $r5
>
> ERROR: spaces required around that ':' (ctx:VxE)
> #1055: FILE: arch/nds32/include/asm/macro.h:89:
> +1:
>   ^

I agree that we can ignore these (or rather try and add exception
rules).


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The number  of  Unix  installations  has  grown  to  10,  with  more
expected."    - The Unix Programmer's Manual, 2nd Edition, June, 1972