[U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files from Linux kernel

[Wolfgang Denk]

Dear Lukasz Majewski,

In message <20111007092838.02c6a42f at lmajewski.digital.local> you wrote:
> 
> > Checkpatch says:
> > 
> > total: 184 errors, 27 warnings, 4301 lines checked
> > 
> > Please clean up and resubmit.  Thanks.
> 
> I'd like to ask about rules for porting - moving files from Linux.

We try to keepo these files unchanged to the extend possile.  But we
also try to add only "clean" code.


> As you can see this file is directly taken from Linux kernel. This code
> has been accepted to kernel mainline.

Yes, but that does not mean that the code is clean.

> So shall I:
> 1. Submit this patch again as is and
> 2. Post a separate patch to remove "warnings and errors" with my sign
> off?
> 
> or:
> 
> 1. Mangle this patch with my correction (186 errors is a lot) and then
> resubmit it with my name included at sign-off?
> Then it won't be anymore a file taken directly from Linux kernel.
> Moreover we will duplicate code, since two different patches with two
> identical functionality will emerge.

The best would be to send cleanup patches to Linux, so we can import a
clean version.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?