[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

Remy Bohmer linux at bohmer.net
Sun Oct 9 11:01:36 CEST 2011


Hi Marek,

>> > > it's hard to evaluate each piece by itself when it's just one patch
>> > > smooshing it all together
>> >
>> > Well how would you rework crap code piece by piece?
>>
>> - fix style
>> - abstract out stuff
>
> Not like there was so much abstraction it couldn't be squashed into this one.
>
>> - add new generic key support
>
> True, this could be separated out. Well, Remy ... what do you think?

A patch that fixes style issues should _only_ fix style issues. It
should not contain any functional change. This makes it all easier to
review. Not only for me, but for everyone else as well.

Kind regards,

Remy


More information about the U-Boot mailing list