[U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

[Wolfgang Denk]

Dear Marek Vasut,

In message <201110092112.18014.marek.vasut at gmail.com> you wrote:
>
> > > +#undef	USB_KBD_DEBUG
> > 
> > Please do not undef what is not defined [or what a user might want to
> > define on the command line].
> 
> Command line ? This is a placeholder in case the user wants to debug this piece 
> of code.

GCC command line.

Please do not add dead code. Remove that line.

> > And please split code changes and pure cosmetic ones into separate
> > commits.  Thanks.
> 
> Well that means I can do all this work one more time :-( I'll get to it 
> sometimes ... later.

Don't blame me.  You should know these rules by now.  You have been
through this more thanonce before.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Documentation is the castor oil of programming.
Managers know it must be good because the programmers hate it so much.