[U-Boot] [PATCH 05/10 v3] spl, nand: add 4bit HW ecc oob first nand_read_page function

Heiko Schocher hs at denx.de
Tue Oct 11 07:41:19 CEST 2011


Hello Scott,

Scott Wood wrote:
> On 10/06/2011 12:45 AM, Heiko Schocher wrote:
>> similiar to commit dc7cd8e59ba077f3b4c1a4557c9cd86a31b9ab1f, only
>> adapted for the new spl framework.
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>> Cc: Scott Wood <scottwood at freescale.com>
>> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
>> Cc: Sandeep Paulraj <s-paulraj at ti.com>
>>
>> ---
>> changes for v3:
>> - add comment from Scott Wood:
>>   as BSS is cleared, no need for intializing vars with 0
>>   remove this.
>>
>>  drivers/mtd/nand/nand_spl_simple.c |   43 +++++++++++++++++++++++++++++++++++-
>>  1 files changed, 42 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/nand_spl_simple.c b/drivers/mtd/nand/nand_spl_simple.c
>> index 71491d4..622a9b5 100644
>> --- a/drivers/mtd/nand/nand_spl_simple.c
>> +++ b/drivers/mtd/nand/nand_spl_simple.c
>> @@ -140,6 +140,47 @@ static int nand_is_bad_block(int block)
>>  	return 0;
>>  }
>>  
>> +#if defined(CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST)
> 
> Change the name to not be 4BIT-specific, and add documentation for this
> config option.

Hmm.. this is no new config option, it enables on davinci socs the
4Bit NAND HW ECC generation ... and I need this in spl code too ...
Ok, you are right, there is no documentation of this config option.
Should I add this documentation in this patch or in a seperate patch?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list