[U-Boot] [PATCH v2 3/3] arm, davinci: add support for am1808 based enbw_cmc board

[Christian Riesch]

Hello Heiko,

On Fri, Oct 7, 2011 at 2:25 PM, Heiko Schocher <hs at denx.de> wrote:
[...]
> ---
>  MAINTAINERS                    |    1 +
>  board/enbw/enbw_cmc/Makefile   |   51 ++++
>  board/enbw/enbw_cmc/enbw_cmc.c |  599 ++++++++++++++++++++++++++++++++++++++++
>  boards.cfg                     |    1 +
>  include/configs/enbw_cmc.h     |  452 ++++++++++++++++++++++++++++++
>  5 files changed, 1104 insertions(+), 0 deletions(-)
>  create mode 100644 board/enbw/enbw_cmc/Makefile
>  create mode 100644 board/enbw/enbw_cmc/enbw_cmc.c
>  create mode 100644 include/configs/enbw_cmc.h
[...]
> diff --git a/include/configs/enbw_cmc.h b/include/configs/enbw_cmc.h
> new file mode 100644
> index 0000000..2c21147
> --- /dev/null
> +++ b/include/configs/enbw_cmc.h
[...]
> +
> +/*
> + * with Pin Setup Utility from TI
> + * missing GPIO pin setup
> + */
> +#define CONFIG_SYS_AM1808_PINMUX0      0x44448888
> +#define CONFIG_SYS_AM1808_PINMUX1      0x48888884
> +#define CONFIG_SYS_AM1808_PINMUX2      0x88888888
> +#define CONFIG_SYS_AM1808_PINMUX3      0x88888888
> +#define CONFIG_SYS_AM1808_PINMUX4      0x22222288
> +#define CONFIG_SYS_AM1808_PINMUX5      0x11111111
> +#define CONFIG_SYS_AM1808_PINMUX6      0x11818811
> +#define CONFIG_SYS_AM1808_PINMUX7      0x11111811
> +#define CONFIG_SYS_AM1808_PINMUX8      0x11111111
> +#define CONFIG_SYS_AM1808_PINMUX9      0x11111111
> +#define CONFIG_SYS_AM1808_PINMUX10     0x11111111
> +#define CONFIG_SYS_AM1808_PINMUX11     0x11111111
> +#define CONFIG_SYS_AM1808_PINMUX12     0x11111111
> +#define CONFIG_SYS_AM1808_PINMUX13     0x88888800
> +#define CONFIG_SYS_AM1808_PINMUX14     0x00000088
> +#define CONFIG_SYS_AM1808_PINMUX15     0x00000000
> +#define CONFIG_SYS_AM1808_PINMUX16     0x88888880
> +#define CONFIG_SYS_AM1808_PINMUX17     0x88888888
> +#define CONFIG_SYS_AM1808_PINMUX18     0x88022288
> +#define CONFIG_SYS_AM1808_PINMUX19     0x08022228

For the pinmux configuration there is already code in
board/davinci/common/davinci_pinmux.c that is used by the boards in
board/davinci/da8xxevm. Would it make sense to move this file to
arch/arm/cpu/arm926ejs/davinci so you could use the same code on your
board instead of having these defines here?

Regards, Christian