[U-Boot] checkpatch compliance

Wolfgang Denk wd at denx.de
Wed Oct 12 20:41:33 CEST 2011


Dear Mike Frysinger,

In message <201110121357.45088.vapier at gentoo.org> you wrote:
>
> > Yes.  The MK_STR() should be cleaned up as well, of course.

Please read as: "... the use of MK_STR() should be cleaned up..."

> some of these can be converted away (like CONFIG_ROOTPATH), but MK_STR() 
> itself cannot go away as we have some defines which normally get used as 
> numbers but we want to embed as a string into the env.  like CONFIG_BAUDRATE.

I did not intend to suggest to remove MK_STR()

> perhaps we should start a top level TODO file where we can start logging al> l 
> the known items we want to get done, and for people who feel like tackling>  
> something crazy, they can pick off items from there.  and for people who ar> e 
> submitting new boards and see these warnings, they can consult the top leve> l 
> TODO to see that "ok, it's a known issue, but i can ignore it in my specifi> c 
> patchset for now".

You mean something like http://www.denx.de/wiki/U-Boot/Tasks ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is a biblical analogy I'd like to draw here.   Casts are to C++
Programmers what the apple was to Eve.         - Scott Douglas Meyers


More information about the U-Boot mailing list