[U-Boot] [PATCH v3 2/2] video: Moving mx3fb.c to CONFIG_VIDEO

Helmut Raiger helmut.raiger at hale.at
Fri Oct 14 08:37:48 CEST 2011


On 10/13/2011 11:16 AM, Anatolij Gustschin wrote:
> From: Helmut Raiger<helmut.raiger at hale.at>
>
> mx3fb.c was based on CONFIG_LCD and is moved by this patch to
> CONFIG_VIDEO, which has greater freedom in selecting videomodes
> even at runtime.
>
> This renders the accumulating list of display defines
> (CONFIG_DISPLAY_VBEST..., CONFIG_DISPLAY_C057...) obsolete as
> these may be setup through env variables:
>
> uboot>  setenv mydisplay 'video=ctfb:x:240,y:320,depth:16,mode:0,pclk:185925,
> 	le:9,ri:17,up:7,lo:10,hs:1,vs:1,sync:100663296,vmode:0'
> uboot>  setenv videomode ${mydisplay}
>
> This commit also fixes the board config files for qong and
> imx31_phycore boards as needed. The videomode settings of
> previously supported displays are added to CONFIG_EXTRA_ENV_SETTINGS
> now. CONFIG_SYS_MALLOC_LEN for imx31_phycore board is increased
> to make the frame buffer allocation working with the changed
> driver.
>
> Signed-off-by: Helmut Raiger<helmut.raiger at hale.at>
> Signed-off-by: Anatolij Gustschin<agust at denx.de>
> Cc: Stefano Babic<sbabic at denx.de>
> ---
> Changes since v2:
>   - fixed commit message
>   - added display info for removed display timings of
>     previously supported displays (in a comment)
>   - fixed compiler warning showed when compiling with debug
>     enabled
>   - added "Video: " prefix before display info output (as
>     we usually do it in U-Boot)
>   - fixed board config files for 'qong' and 'imx31_phycore' boards
>     so that this commit doesn't break compiling (bisectable now)
>   - added videomode settings for previously supported displays on
>     'qong' and 'imx31_phycore' to CONFIG_EXTRA_ENV_SETTINGS
>   - increased CONFIG_SYS_MALLOC_LEN for 'imx31_phycore' so that
>     the frame buffer can be allocated now (this is required to make
>     the display support working with the changed mx3fb driver)
>
Hi Anatolij,

     I'm fine with your changes. It still works on our board. Thanks for 
testing and improving.

Helmut




--
Scanned by MailScanner.



More information about the U-Boot mailing list