[U-Boot] [PATCH v2] NS16550: buffer reads

[Wolfgang Denk]

Dear Simon Glass,

In message <CAPnjgZ3wZo4nkP2GjKbS_r8AWmRaCkagFDqrXrJg5MniykxCNw at mail.gmail.com> you wrote:
> 
> The situation this occurs is when you paste characters into a serial
> terminal connected to U-Boot. This is a pretty common requirement. Yes
> you can manually select each line and paste it but that is a pain.

But that's exactly how it's supposed to work.  Depending on hardware
that may or may not be FIFOs available to buffer such asynchronous
input, and I rather see limited, but consistent behaviour, instead of
fancy stuff that works oin one board but not on another.

> With this patch it is possible to paste a series of 'setenv' commands,
> for example.

If you want to run multi-line command sequences, then load and run a
script.

In the special case of setting environment variables, consider using
featurs like "env import" instead.

> This caused an awful lot of confusion here because characters would be
> silently dropped within the command line (normally about 16 chars from
> the end). Then the system would not boot. It is really not a friendly
> experience.

There should never be character loss when sending data on a line by
line base.  Even the slowest processors we support are fast enough to
deal with that.

Multi-line input has never been supported.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alan Turing thought about criteria to settle the question of  whether
machines  can think, a question of which we now know that it is about
as relevant as the question of whether submarines can swim.
                                                   -- Edsger Dijkstra