[U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask

Sergei Shtylyov sshtylyov at mvista.com
Sat Oct 15 22:34:37 CEST 2011


Hello.

On 12-10-2011 15:31, Christian Riesch wrote:

> MDSTAT.STATE occupies bits 0..5 according to all available documentation,
> therefore change the bitmask to 0x3f.

> Signed-off-by: Christian Riesch<christian.riesch at omicron.at>
> Cc: Heiko Schocher<hs at denx.de>
> Cc: Paulraj Sandeep<s-paulraj at ti.com>
> Cc: Albert ARIBAUD<albert.u.boot at aribaud.net>
> Cc: Sergei Shtylyov<sshtylyov at ru.mvista.com>
> ---
>   arch/arm/cpu/arm926ejs/davinci/psc.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/arch/arm/cpu/arm926ejs/davinci/psc.c b/arch/arm/cpu/arm926ejs/davinci/psc.c
> index 8273a7f..486adb0 100644
> --- a/arch/arm/cpu/arm926ejs/davinci/psc.c
> +++ b/arch/arm/cpu/arm926ejs/davinci/psc.c
> @@ -83,7 +83,7 @@ void lpsc_on(unsigned int id)
>   	while (readl(ptstat)&  0x01)
>   		continue;
>
> -	if ((readl(mdstat)&  0x1f) == 0x03)
> +	if ((readl(mdstat)&  0x3f) == 0x03)
>   		return; /* Already on and enabled */
>
>   	writel(readl(mdctl) | 0x03, mdctl);
> @@ -114,7 +114,7 @@ void lpsc_on(unsigned int id)
>
>   	while (readl(ptstat)&  0x01)
>   		continue;
> -	while ((readl(mdstat)&  0x1f) != 0x03)
> +	while ((readl(mdstat)&  0x3f) != 0x03)
>   		continue;
>   }

    This patch is incomplete but I guess you've figured that out already as 
you've commented on my analogous patch. So marking for the custodian -- don't 
apply this patch.

WBR, Sergei


More information about the U-Boot mailing list