[U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

Wolfgang Denk wd at denx.de
Sun Oct 16 08:15:50 CEST 2011


Dear Vadim Bendebury,

In message <CAC3GErGRvV0PjWt47d1dQ=D5B3kv+Bge0jsxdZSYWEPSvbekLw at mail.gmail.com> you wrote:
>
> > Make it an inline function then, this will do the typechecking for you.
> 
> I am not sure what is wrong with a short macro in this case - is this
> against the coding style?

"Documentation/CodingStyle":

	Generally, inline functions are preferable to macros
	resembling functions.

Marek listed one (important) reason why this is the case.

So please change this.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"'Tis true, 'tis pity, and pity 'tis 'tis true."
    - Poloniouius, in Willie the Shake's _Hamlet, Prince of Darkness_


More information about the U-Boot mailing list