[U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

[Wolfgang Denk]

Dear Vadim Bendebury,

In message <CANy1buJCjdQnpQ6EHTjJ3jOvGe5fKqDoDpevofhu6_-2Y7L6gg at mail.gmail.com> you wrote:
> 
> Also, what about situations when one reviewer requests a certain
> implementation and another one finds it inappropriate?

Here we had several people (Marek and me) asking the same thing.
And actually my message was intended to tell you that I agree with
Marek.

In case of doubt, someone has to make a final decision.

In this specific case I already decided (and told you) that I want to
see a function instead of a macro.

> Can you please also confirm that having a structure with a single
> element as an array is "weird" and must be changed to passing around a
> pointer to a single element without the size (or maybe the idea is
> that the pointer AND the size need to be passed around)?

Yes, I consider this weird, too.  And you failed to provide a good
explanation why you think this would be needed so far.

> Are macros acceptable to wrap input output with debug messages, as was
> suggested earlier on this list, or should I replace each macro with
> two inline functions?

Sorry, I don't remember which code you are referring to here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I'm growing older, but not up."                      - Jimmy Buffett