[U-Boot] [PATCH v6 18/20] Adjust dependency rules to permit per-file flags

[Simon Glass]

Hi Wolfgang,

On Tue, Oct 18, 2011 at 7:08 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Wolfgang,
>
> On Mon, Oct 17, 2011 at 10:46 PM, Wolfgang Denk <wd at denx.de> wrote:
>> Dear Simon Glass,
>>
>> In message <1318270953-32482-19-git-send-email-sjg at chromium.org> you wrote:
>>> The dependency rules are currently done in a shell 'for' loop. This does not
>>> permit Makefile variables to adjust preprocessor flags as is done with normal
>>> compile flags, using the CFLAGS_path/file.o syntax.
>>>
>>> This change moves the dependency generation into the Makefile itself, and
>>> permits a CPPFLAGS_path/file.o to adjust preprocessor flags on a file or
>>> directory basis.
>>>
>>> The CPPFLAGS_... variable is also folded into CFLAGS during the build.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>
>> This commit breaks building a number of PPC boards like that:
>>
>> Configuring for acadia_nand - Board: acadia, Options: NAND_U_BOOT,SYS_TEXT_BASE=0x01000000
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/start.S: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/resetvec.S: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/cache.S: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/gpio.c: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/nand_boot.c: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/nand_ecc.c: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/memory.c: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/ndfc.c: No such file or directory
>> ppc_6xx-gcc: no input files
>> ppc_6xx-gcc: /work/wd/tmp-ppc/nand_spl/board/amcc/acadia/pll.c: No such file or directory
>> ppc_6xx-gcc: no input files
>> make[1]: *** No rule to make target `/work/wd/tmp-ppc/nand_spl/board/amcc/acadia/.depend', needed by `all'.  Stop.
>>
>>
>> Affected boards:
>>
>>        MPC8313ERDB_NAND_33     P1020RDB_NAND           SIMPC8313_LP
>>        MPC8313ERDB_NAND_66     P1021RDB-PC_36BIT_NAND  SIMPC8313_SP
>>        MPC8315ERDB_NAND        P1021RDB-PC_NAND        acadia_nand
>>        MPC8536DS_NAND          P1023RDS_NAND           bamboo_nand
>>        MPC8569MDS_NAND         P1024RDB_NAND           canyonlands_nand
>>        MPC8572DS_NAND          P1025RDB_NAND           glacier_nand
>>        P1010RDB_36BIT_NAND     P2010RDB_NAND           haleakala_nand
>>        P1010RDB_NAND           P2020RDB-PC_36BIT_NAND  kilauea_nand
>>        P1011RDB_NAND           P2020RDB-PC_NAND        rainier_nand
>>        P1020RDB-PC_36BIT_NAND  P2020RDB_NAND           sequoia_nand
>>        P1020RDB-PC_NAND
>>
>
> This might be something to do with SPL - I am looking at it today.
>
> Regards,
> Simon
>
>> Please fix.

I have submitted a patch for this, tested on acadia like this:

ARCH=powerpc make O=ppc -s acadia_nand_config && ARCH=powerpc make O=ppc -s

and similarly without the O= part.

Regards,
Simon

>>
>> Best regards,
>>
>> Wolfgang Denk
>>
>> --
>> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
>> Documentation is the castor oil of programming.
>> Managers know it must be good because the programmers hate it so much.
>>
>