[U-Boot] [PATCH] bootm: Use "panic()" in non-recoverable error conditions

Wolfgang Denk wd at denx.de
Thu Oct 20 21:31:25 CEST 2011


Dear Kyle Moffett,

In message <1319134031-28503-1-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> All of these errors are various kinds of fatal memory overwrite
> conditions and so should be handled by panic().  This fixes a bug in
> which the error message might not get all the way out to the serial
> console before the system reboots; panic() has a built-in delay after
> doing a printf() before calling do_reset().
> 
> This will result in a change in behavior for the 27 board configuration
> files which set CONFIG_PANIC_HANG (less than 5% of the total).  They
> will now hang in those fatal error conditions instead of trying to
> reboot.
> 
> Given that CONFIG_PANIC_HANG is intended to prevent the system from
> rebooting after it has encountered an unrecoverable error, this seems to
> be the desired behavior for those 27 board configurations.

This is your interpretation, but the users and especially the
respective board maintainers may think different.  We should at least
try and get feedback from them first.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's all Klatchian to me.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_


More information about the U-Boot mailing list