[U-Boot] [PATCH] mii: miiphy register address width change

Wolfgang Denk wd at denx.de
Fri Oct 21 12:03:21 CEST 2011


Dear "Kumar Nath, Chandan",

In message <B85A65D85D7EB246BE421B3FB0FBB5930328B2D9DC at dbde02.ent.ti.com> you wrote:
>
> > I don't think the patch is correct or incorrect. It attempts to update
> > the miiphy_* API to support larger register offsets. I'm suggesting
> > that we shouldn't change the legacy API to support new features.
> > There's no way to specify via miiphy_write that you want to write to a
> > register with a 16-bit register offset, because there's no way to
> > specify which device to write.
> > >
> > So I'm not saying we shouldn't apply this patch. I'm questioning why
> > it was written in a hope that we can discourage new use of the old
> > API. I'm also not convinced the patch helps anything.
> > >
> > Andy
>
> This patch was written to support PHY register whose address width is great> er
> than 8 bit. It was not written for 10 gig support.

The question remains:  Why are you still using the old deprecated
legacy API instead of the new one?

You will need really good reasons to convince me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Save energy:  Drive a smaller shell.


More information about the U-Boot mailing list