[U-Boot] [PATCH v2 1/3] Add limits.h to hold basic limits

[Albert ARIBAUD]

Le 21/10/2011 22:19, Simon Glass a écrit :
> Hi Albert,
>
> On Fri, Oct 21, 2011 at 12:54 PM, Albert ARIBAUD
> <albert.u.boot at aribaud.net>  wrote:
>> Hi Simon,
>>
>> Le 10/10/2011 21:22, Simon Glass a écrit :
>>>
>>> This brings a basic limits.h implementation into U-Boot.
>>>
>>> Signed-off-by: Simon Glass<sjg at chromium.org>
>>> ---
>>>   fs/ubifs/ubifs.h |    4 +---
>>>   include/limits.h |   40 ++++++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 41 insertions(+), 3 deletions(-)
>>>   create mode 100644 include/limits.h
>>
>> Apparently, in all the U-Boot codebase, only one file required standard
>> limit names, and gets them with three lines of code. Is it worth adding 40
>> lines of code for this?
>
> Well 2/3 is the license header - and I thought it best to add all the
> limits in one go. I can add just those few if you like.
>
> This file is used later in the patch series.

I don't see much use of these in the subsequent patches either -- and 
those few uses could be discussed, such as for instance the use of 
INT_MAX as the maximum buffer size for some *printf() functions -- 
actually, anything very big would fit just as well, would it not?

> Regards,
> Simon

Amicalement,
-- 
Albert.