[U-Boot] [PATCH V6 2/6] Add cmd_spl command

[Wolfgang Denk]

Dear Simon Schwarz,

In message <1317284033-16188-3-git-send-email-simonschwarzcor at gmail.com> you wrote:
> This adds a spl command to the u-boot.
> 
> Related config:
> CONFIG_CMD_CPL
> 	activate/deactivate the command
> CONFIG_CMD_SPL_NAND_OFS
> 	Offset in NAND to use
> 
> Signed-off-by: Simon Schwarz <simonschwarzcor at gmail.com>
...
> +++ b/common/cmd_spl.c
> @@ -0,0 +1,214 @@
> +/* Copyright (C) 2011
> + * Corscience GmbH & Co. KG - Simon Schwarz <schwarz at corscience.de>

Incorrect multiline comment style.

> +int spl_export_fdt(int argc, char * const argv[])
> +{
> +#ifdef CONFIG_OF_LIBFDT
> +	/* Create subcommand string */
> +	char *subcommand[] = {"start", "loados",
> +#ifdef CONFIG_SYS_BOOT_RAMDISK_HIGH
> +	"ramdisk",
> +#endif
> +	"fdt", "cmdline", "bdt", "prep", '\0'};

Please format struct entries one per line.

> +	char *subcommand[] = {"start", "loados",
> +#ifdef CONFIG_SYS_BOOT_RAMDISK_HIGH
> +	"ramdisk",
> +#endif
> +	"cmdline", "bdt", "prep", '\0'};

Ditto.

> +/* Arguments:
> + * 1: subcommand
> + * 2: image_type
> + * 3: nand_offset
> + * 4: kernel_addr
> + * 5: initrd_addr
> + * 6: fdt_adr */

Incorrect multiline comment style.

> +/* Copyright (C) 2011
> + * Corscience GmbH & Co. KG - Simon Schwarz <schwarz at corscience.de>

Incorrect multiline comment style.

Please fix globally.


> +#define SPL_EXPORT	(0x00000001)
> +
> +#define SPL_EXPORT_FDT		(0x00000001)
> +#define SPL_EXPORT_ATAGS	(0x00000002)

Please remove unnecessary parens.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You ain't experienced..." "Well, nor are you." "That's true. But the
point is ... the point is ... the point is we've been not experienced
for a lot longer than you. We've got  a  lot  of  experience  of  not
having any experience."           - Terry Pratchett, _Witches Abroad_