[U-Boot] [PATCH 1/2] Create a single cmd_call() function to handle command execution

Wolfgang Denk wd at denx.de
Tue Oct 25 20:20:37 CEST 2011


Dear Graeme Russ,

In message <4EA66D4C.8010506 at gmail.com> you wrote:
> 
> > What exactly is the purpose of this additional function?  Except for
> > the debug() it provides only overhead and no benefit.
> 
> It provides a single location to issue an XOFF immediately prior to running
> a (potentially long running) command
> 
> > I don't think I want to have that.
> 
> Well it does make things cleaner if we do end up implementing software flow
> control

If, and only if.  _And_ if we agree that we should hook into command
execution, which I don't consider a good idea.

Serial flow control has nothing to do with that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can fool some of the people all of the time, and You can fool all
of the people some of the time, but You can't fool mom.


More information about the U-Boot mailing list