[U-Boot] [PATCH 0/5] altera_tse: Several small, but relevant fixes/feature

[Thomas Chou]

On 10/25/2011 04:21 PM, Joachim Foerster wrote:
> Hi all,
>
> Did anybody get a chance to review those 5 small patches? I would like
> to get some feedback and work on it, if needed - to get them upstream.
>

Hi Joachim,

I forwarded your patches to Dalon Westergreen of Altera on Oct 20, who 
is the author of this driver. I asked Dalon to help to review your patches.

I run checkpatch.pl and there are minors warnings. You may fix them 
after we get feedback from Dalon.

WARNING: braces {} are not necessary for any arm of this statement
#55: FILE: drivers/net/altera_tse.c:586:
+    if ((priv->flags >= 1) && (priv->flags <= 4)) {
[...]
+    } else if (priv->flags == 5) {
[...]

WARNING: braces {} are not necessary for single statement blocks
#68: FILE: drivers/net/altera_tse.c:598:
+    if ((priv->flags >= 1) && (priv->flags <= 4)) {
+        mii_data |= 0x82;
+    }

I am going to test your patches on 3C120 and NEEK boards. And will let 
you know my results.

Best regards,
Thomas