[U-Boot] [PATCH 3/3] net: Be less picky about decoding the netretry env var

Simon Glass sjg at chromium.org
Thu Oct 27 15:35:08 CEST 2011


Hi Mike,

On Wed, Oct 26, 2011 at 11:00 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thu, Oct 27, 2011 at 02:18, Simon Glass wrote:
>> --- a/net/net.c
>> +++ b/net/net.c
>>
>> -               if (!strcmp(nretry, "yes"))
>> +               if (*nretry == 'y')
>
> not sure about this as it makes it hard to add code in the future if
> we care about compatibility.  if we support just "y", people will
> start using it.
> -mike
>

Yes, I'm not sure either. I have found a few env variables that use
single letters (autoload, flashchecksum) and noticed that quite a few
commands only decode as much of their subcommand as they need to be
unique. I am happier with y and n than o!

Regards,
Simon


More information about the U-Boot mailing list