[U-Boot] [PATCH] e1000: fix bugs from recent commits

[Wolfgang Denk]

Dear "Moffett, Kyle D",

In message <FEA1AB06-A66F-4180-A2B3-076E7C719FC9 at boeing.com> you wrote:
>
> The correct E1000_WRITE_FLUSH macro should be:
>   #define E1000_WRITE_FLUSH(a) \
>           do { uint32_t x =3D E1000_READ_REG(a, STATUS); (void)x; } while(0=
> )
> 
> It shouldn't return a value, it's just ensuring that writes are properly
> posted to the PCI bus.

Really? Should that not be guaranteed by the memory barriers inside
the E1000_READ_REG() code?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Here's a fish hangs in the net like a poor man's right in  the  law.
'Twill hardly come out."     - Shakespeare, Pericles, Act II, Scene 1