[U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

Marek Vasut marek.vasut at gmail.com
Sun Oct 30 23:19:23 CET 2011


> Dear Marek Vasut,
> 
> In message <201110302148.50367.marek.vasut at gmail.com> you wrote:
> > > > -	addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr));
> > > > +	addr_lo = cpu_to_le32(*eth->enetaddr);
> > > 
> > > pretty sure this is wrong.  enetaddr is a uchar[], so your code now
> > > reads only 1 byte instead of 4.
> > > 
> > > that said, this code also seems to not be endian safe ...
> > > -mike
> > 
> > It's good anyone actually cares to properly review. Anyway, why does
> > noone actually care to fix all the damn warnings in their drivers before
> > submitting them in the first place ?!
> 
> GCC 4.6 has not been around that long.  Many people use less
> bleading-edge tool chains - for a good reason.

The problem is I saw this warning with gcc 4.2 too :-(

Cheers


More information about the U-Boot mailing list