[U-Boot] [PATCH 3/7] omap/spl: actually enable the console

Tom Rini tom.rini at gmail.com
Mon Oct 31 15:44:12 CET 2011


On Mon, Oct 31, 2011 at 5:39 AM, Ilya Yanok <yanok at emcraft.com> wrote:
> Hi Tom,
>
>>> Currently OMAP SPL code does all the initialization but does not set the
>>> gd->have_console value so no output is actually performed. This patch
>>> sets gd->have_console to 1 if CONFIG_SPL_CONSOLE is defined.
>>>
>>> Signed-off-by: Ilya Yanok <yanok at emcraft.com>
>>
>> So, this is because of a behavior change.  Do we want an SPL_CONSOLE variable?
>> Or should we just bring back the previous behavior?  I kind of think
>> the previous
>> behavior...  Others?
>
> So what will be your decision? Should I remove SPL_CONSOLE and repost
> the patch? Or should I drop it completely?

I would say just drop the #ifdef part.

-- 
Tom


More information about the U-Boot mailing list