[U-Boot] [PATCH] cmd_bdinfo: simplify local static funcs a bit

Simon Glass sjg at chromium.org
Mon Oct 31 21:47:08 CET 2011


Hi Mike,

On Mon, Oct 31, 2011 at 1:44 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 31 October 2011 15:11:35 Simon Glass wrote:
>> On Sun, Oct 30, 2011 at 5:54 PM, Mike Frysinger <vapier at gentoo.org> wrote:
>> > If we move the local funcs to the top of the file, and use the
>> > __maybe_unused define, we can drop a lot of ugly ifdef logic and
>> > duplicated prototypes.
>> >
>> > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
>>
>> This is much cleaner - is the correct style to put attribute tags on
>> the previous line?
>
> when responding to add your own, there isn't any real protocol.  just normal
> e-mail etiquette (no top posting/etc...).  patchwork/humans will do the right
> thing when manually updating the changelog.
> -mike
>

Actually I meant the __maybe_unused tag before the function name.

Regards,
Simon


More information about the U-Boot mailing list