[U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'
premi at ti.com
Sat Sep 3 09:28:59 CEST 2011
> From: Wolfgang Denk [wd at denx.de]
> Sent: Saturday, September 03, 2011 3:37 AM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] omap3evm: Set environment variable 'ethaddr'
> Dear "Premi, Sanjeev",
> In message <B85A65D85D7EB246BE421B3FB0FBB5930257371E07 at dbde02.ent.ti.com> you wrote:
> > > Your patch always and unconditionally overwrites any existing
> > > "ethaddr" settings. This is not acceptable.
> > For the EVM, MAC address is always probed from the chip. Hence, I
> > assumed it safe to set the ethaddr - without checking for env var.
> This is not what we do in U-Boot, so please fix that.
> > It was unlikely that someone would be setting it - to different
> > value.
> Unlikely? Not so. This is expected standard behaviour. Please don't
> try to invent a wheel (in a different shape).
[sp] I agreed with your comments in the next para. Had only
described my thoughts before creating this patch.
You seem to have missed the v2 of the same patch where I
believe I have taken care of this behavior:
Do let me know if this is better...
> Best regards,
> Wolfgang Denk
More information about the U-Boot