[U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

[Prabhakar Lad]

Hi Jaehoon,

On Thu, Apr 12, 2012 at 4:29 PM, Jaehoon Chung <jh80.chung at samsung.com> wrote:
> To support sdhci controller, remove the CONFIG_S5P_MMC..
> Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI.
>
> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> Acked-by: Lei Wen<leiwen at marvell.com>
> ---
>  include/configs/origen.h            |    3 ++-
>  include/configs/s5p_goni.h          |    3 ++-
>  include/configs/s5pc210_universal.h |    3 ++-
>  include/configs/smdk5250.h          |    3 ++-
>  include/configs/smdkv310.h          |    3 ++-
>  include/configs/trats.h             |    3 ++-
>  6 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/include/configs/origen.h b/include/configs/origen.h
> index 8ede825..ea8066f 100644
> --- a/include/configs/origen.h
> +++ b/include/configs/origen.h
> @@ -71,7 +71,8 @@
>  /* SD/MMC configuration */
>  #define CONFIG_GENERIC_MMC             1
>  #define CONFIG_MMC                     1
> -#define CONFIG_S5P_MMC                 1
> +#define CONFIG_SDHCI                   1
> +#define CONFIG_S5P_SDHCI               1
>
>  /* PWM */
>  #define CONFIG_PWM                     1
> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
> index 56b5547..f659699 100644
> --- a/include/configs/s5p_goni.h
> +++ b/include/configs/s5p_goni.h
> @@ -65,7 +65,8 @@
>  /* MMC */
>  #define CONFIG_GENERIC_MMC             1
>  #define CONFIG_MMC                     1
> -#define CONFIG_S5P_MMC                 1
> +#define CONFIG_SDHCI                   1
> +#define CONFIG_S5P_SDHCI               1
>
>  /* PWM */
>  #define CONFIG_PWM                     1
> diff --git a/include/configs/s5pc210_universal.h b/include/configs/s5pc210_universal.h
> index 1301275..241d209 100644
> --- a/include/configs/s5pc210_universal.h
> +++ b/include/configs/s5pc210_universal.h
> @@ -68,7 +68,8 @@
>  /* MMC */
>  #define CONFIG_GENERIC_MMC     1
>  #define CONFIG_MMC             1
> -#define CONFIG_S5P_MMC         1
> +#define CONFIG_SDHCI           1
> +#define CONFIG_S5P_SDHCI       1
>
>  /* PWM */
>  #define CONFIG_PWM                     1
> diff --git a/include/configs/smdk5250.h b/include/configs/smdk5250.h
> index 9659f9e..0f63040 100644
> --- a/include/configs/smdk5250.h
> +++ b/include/configs/smdk5250.h
> @@ -78,7 +78,8 @@
>  /* SD/MMC configuration */
>  #define CONFIG_GENERIC_MMC
>  #define CONFIG_MMC
> -#define CONFIG_S5P_MMC
> +#define CONFIG_SDHCI
> +#define CONFIG_S5P_SDHCI
    There is no consistency for the #define  CONFIG_S5P_SDHCI,
    few have been assigned to value 1, And looking at the patchset
    the value of it is not used if I am not wrong, depending or defined
    or not some file is built. Best way could be not to assign any value
    for such cases, just  #define CONFIG_S5P_SDHCI would make
    sense. It would be good If you also do the same for other CONFIG'S
    defined.

Thx,
--Prabhakar Lad

>
>  #define CONFIG_BOARD_EARLY_INIT_F
>
> diff --git a/include/configs/smdkv310.h b/include/configs/smdkv310.h
> index 93c25da..077f0e0 100644
> --- a/include/configs/smdkv310.h
> +++ b/include/configs/smdkv310.h
> @@ -70,7 +70,8 @@
>  /* SD/MMC configuration */
>  #define CONFIG_GENERIC_MMC             1
>  #define CONFIG_MMC                     1
> -#define CONFIG_S5P_MMC                 1
> +#define CONFIG_SDHCI                   1
> +#define CONFIG_S5P_SDHCI               1
>
>  /* PWM */
>  #define CONFIG_PWM                     1
> diff --git a/include/configs/trats.h b/include/configs/trats.h
> index 10f11d9..71b9393 100644
> --- a/include/configs/trats.h
> +++ b/include/configs/trats.h
> @@ -74,7 +74,8 @@
>  /* MMC */
>  #define CONFIG_GENERIC_MMC
>  #define CONFIG_MMC
> -#define CONFIG_S5P_MMC
> +#define CONFIG_S5P_SDHCI
> +#define CONFIG_SDHCI
>
>  /* PWM */
>  #define CONFIG_PWM
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot