[U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

[Graeme Russ]

Hi Prabhakar,

On Fri, Apr 13, 2012 at 4:16 PM, Prabhakar Lad
<prabhakar.csengg at gmail.com> wrote:
> Hi Jaehoon,
>

[snip]

>    There is no consistency for the #define  CONFIG_S5P_SDHCI,
>    few have been assigned to value 1, And looking at the patchset
>    the value of it is not used if I am not wrong, depending or defined
>    or not some file is built. Best way could be not to assign any value
>    for such cases, just  #define CONFIG_S5P_SDHCI would make
>    sense. It would be good If you also do the same for other CONFIG'S
>    defined.

All boolean defines should be #define'd with no value

Patches should be submitted to cleanup any that are currently defined with
a value. Such patches should be marked 'cosmetic' and be distinctly
seperate from any patches that are adding new code, prefferable prior to
the patches addding new defines so each file always has a consistent style

Regards,

Graeme