[U-Boot] [PATCH 2/2] EXYNOS: draw 32bpp bitmap TIZEN logo

Wolfgang Denk wd at denx.de
Mon Apr 23 11:22:16 CEST 2012


Dear Donghwa Lee,

In message <4F94B49E.5020802 at samsung.com> you wrote:
> This patches support drawing 32bpp bitmap TIZEN logo in exynos fb.
> asm/arch/trats_logo.h data is compressed by zip and decomressed at 
> the exynos fb driver.
> 
> And vl_bpix of vidinfo_t is changed proper value for u-boot.
> 
> Signed-off-by: Donghwa Lee <dh09.lee at samsung.com>
> Signed-off-by: Kyungmin park <kyungmin.park at samsung.com>
> ---
>  arch/arm/include/asm/arch-exynos/trats_logo.h | 5070 +++++++++++++++++++++++++
>  board/samsung/trats/trats.c                   |    2 +-
>  drivers/video/exynos_fb.c                     |   40 +-
>  drivers/video/exynos_fimd.c                   |    6 +-
>  include/configs/trats.h                       |    4 +-
>  5 files changed, 5116 insertions(+), 6 deletions(-)
>  create mode 100644 arch/arm/include/asm/arch-exynos/trats_logo.h
> 
> diff --git a/arch/arm/include/asm/arch-exynos/trats_logo.h b/arch/arm/include/asm/arch-exynos/trats_logo.h
> new file mode 100644
> index 0000000..a595abd
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-exynos/trats_logo.h

This is not a good location for the logo data.  Either this is vendor
specific, in which place it should go to the vendor directory, or it's
board specific, in which case it should go into the board directory.

In no case I want to have this in arch/arm/include/

thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember, there's a big difference between kneeling down and  bending
over.                                                   - Frank Zappa


More information about the U-Boot mailing list