[U-Boot] [PATCH 3/4][v3] powerpc/85xx:Make debug exception vector accessible

[Andy Fleming]

On Tue, Apr 24, 2012 at 4:10 PM, Scott Wood <scottwood at freescale.com> wrote:
> On 04/24/2012 03:45 PM, Andy Fleming wrote:
>> On Mon, Mar 26, 2012 at 4:00 AM, Prabhakar Kushwaha
>>> @@ -107,6 +107,7 @@
>>>  #define CONFIG_MAX_CPUS                        1
>>>  #define CONFIG_FSL_SDHC_V2_3
>>>  #define CONFIG_SYS_FSL_NUM_LAWS                12
>>> +#define CONFIG_SYS_PPC_E500_DEBUG_TLB  3
>>
>>
>> You've only enabled this for one processor. Maybe the P1010. Nowhere
>> in the patch description does it mention that this is only being
>> enabled for one chip. As it is, I think you meant to enable it for
>> more chips, and I'm wondering why it's not enabled for the other chips
>> mentioned in the comments above as being test platforms for this
>> patch...
>>
>> Probably, for this feature, we should make a default definition, which
>> can be overridden by other parts if necessary.
>>
>> In other words, add something like this near the end:
>>
>> #ifndef CONFIG_SYS_PPC_E500_DEBUG_TLB
>> #define CONFIG_SYS_PPC_E500_DEBUG_TLB 3
>> #endif
>
> We don't want to enable this on e500mc (testing in that context just
> means that we didn't break the code path where this isn't enabled).  I'm
> not sure whether it will break anything if we do enable it on e500mc,
> but we don't need it.

Ok, but we still either need this to be enabled for all e500/e500v2.
OR split off this config option into a separate patch where it's
mentioned that this is only being enabled on the P1010.

Actually, it should probably be added to this area that deals in
core-specific config options:

#if defined(CONFIG_E500MC)
#define CONFIG_SYS_NUM_TLBCAMS          64
#elif defined(CONFIG_E500)
#define CONFIG_SYS_NUM_TLBCAMS          16
-->
#endif


Andy