[U-Boot] [PATCH v2 4/4] lin_gadget: use common linux/compat.h

Anatolij Gustschin agust at denx.de
Thu Apr 26 12:55:40 CEST 2012


Hi Lukasz,

On Thu, 26 Apr 2012 12:32:40 +0200
Lukasz Majewski <l.majewski at samsung.com> wrote:
...
> > Now I see another issue. In this 4/4 patch we are removing kmalloc:
> > 
> > -#define kmalloc(size, type) memalign(CONFIG_SYS_CACHELINE_SIZE, size)
> > 
> > linux/compat.h defines kmalloc() to be malloc(), so the gadget driver
> > should probably use memalign() directly where it is needed?
> 
> In the include/usb/lin_gadget_compat.h the
> 
> #define kmalloc(size, type) memalign(CONFIG_SYS_CACHELINE_SIZE, size)
> line is defined.
> 
> I think that memalign can be used directly, no problem.

Okay, I'll change this patch accordingly and will resubmit v3 then.

Thanks,
Anatolij


More information about the U-Boot mailing list