[U-Boot] [PATCH] video: cfb_console: flush dcache for frame buffer in DRAM

[Anatolij Gustschin]

Hi Mike,

On Sat, 28 Apr 2012 14:16:39 -0400
Mike Frysinger <vapier at gentoo.org> wrote:

> On Saturday 28 April 2012 11:04:07 Anatolij Gustschin wrote:
> > +static int cfb_fb_is_in_dram(void)
> > +{
> > +	bd_t *bd = gd->bd;
> > +	ulong start, end;
> > +	int i;
> > +
> > +	for (i = 0; i < CONFIG_NR_DRAM_BANKS; ++i) {
> > +#if defined(CONFIG_ARM) || defined(CONFIG_AVR32) || defined(COFNIG_NDS32)
> > || \ +defined(CONFIG_SANDBOX) || defined(CONFIG_X86)
> > +		start = bd->bi_dram[i].start;
> > +		end = bd->bi_dram[i].start + bd->bi_dram[i].size - 1;
> > +#else
> > +		start = bd->bi_memstart;
> > +		end = bd->bi_memsize;
> > +#endif
> > +
> > +		if ((ulong)video_fb_address >= start &&
> > +		    (ulong)video_fb_address < end)
> > +			return 1;
> > +	}
> > +	return 0;
> > +}
> 
> is this necessary ?  the cache funcs should take care of this automatically.

Currently they don't, or at least on some architectures. Or did you mean
that the cache instructions should take care of this?

Thanks,
Anatolij