[U-Boot] [PATCH 4/5] README: The ver env var is not read-only

Benoît Thébaudeau benoit.thebaudeau at advansee.com
Sun Aug 12 15:58:24 CEST 2012


Dear Wolfgang Denk,

> > I had thought about that, but there is an issue. main_loop() sets
> > this env var,
> > so if ver is made read-only and the env is stored somewhere (NVRAM,
> > etc.), then
> > after an update of U-Boot with a newer version (stored env
> > untouched), ver will
> > still indicate the older version. See commit 155cb01, which forgot
> > to update the
> 
> No.  main_loop() will always set this variable to the right value, no
> matter what might be stored in the environment.  Only if you then
> change i later you may (temporarily) see a different value.  But
> again
> only until you reset the board.

Yes, I agree. The behavior that I described is what would occur _if_ commit
155cb01 were reverted in order to make ver truly read-only like Mike asked for.
The current behavior is not too bad for now.

> The correct fix for this would be the introduction of variable types,
> including flags like "read-only" (as for serial# or ethaddr) or
> "volatile" (i. e. not included in saveenv, as for filesize etc.)
> 
> I have been thinking about this for a long time already, I just
> didn't
> find time yet to implement it.

OK. Don't you think that the README file should be updated in some way in the
meantime to reflect this, since ver is neither read-only nor "normal"?

Best regards,
Benoît


More information about the U-Boot mailing list