[U-Boot] [PATCH 0/57] RFC: Move arch-specific global data into its own structure

Wolfgang Denk wd at denx.de
Tue Dec 4 20:20:22 CET 2012


Dear Tom,

In message <20121203145414.GE15777 at bill-the-cat> you wrote:
> 
> > > - The change makes the code less readable.  Reading "gd->arch."
> > >   instead of plain "gd->" is no improvements, but rather vice versa.
> > >   If we really go this way, this should be improved.
> > 
> > Yes it would be nice. Are you suggesting some sort of macro, or
> > something else?
>
> Wolfgang?  "global data, architecture specific goo, ..." reads fine and
> helpful to me, honestly.

Well, maybe, at first glance. But when you read (and write) it again
and again and again it quickly becomes a PITA.  It's similar to a
nested pull-down menu - when you use it the first time, it's nice that
you don't have to remember the exact command name and/or options to
perform operation foo - but when you find yourself doing this many
times a day, you will highly prefer to type a short command on the
command line over having to pull down three or four nested levels in
some pull-down menu.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As a general rule, the freedom of any people can  be  judged  by  the
volume of their laughter.


More information about the U-Boot mailing list