[U-Boot] [PATCH v2] imls: Add support to list images in NAND device

[Vipin Kumar]

On 12/13/2012 1:54 AM, Wolfgang Denk wrote:
> Dear Vipin Kumar,
>
> In message<dba14c4ffef38a108f75342968bcd9ce2b75c4c7.1355303894.git.vipin.kumar at st.com>  you wrote:
>> imls does not list the images in NAND devices. This patch implements this
>> support for legacy type images.
> ...
>> -static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +static void do_imls_flash(void)
>
> Why is this void?  Should we not return error codes? Or at least be
> able to?
>

Yes, I agree. I would change this

>> +static void do_imls_nand(void)
>
> Ditto.
>
>
> Best regards,
>
> Wolfgang Denk
>