[U-Boot] [PATCH 6/9] mx28evk: Add support to dynamically choose between ftd use or not

[Otavio Salvador]

On Wed, Dec 26, 2012 at 9:15 AM, Stefano Babic <sbabic at denx.de> wrote:
> On 21/12/2012 17:59, Otavio Salvador wrote:
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> ---
>
> Hi Otavio,
>
>>  include/configs/mx28evk.h |   15 +++++++++++++--
>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
>> index 3cc0726..5c1c052 100644
>> --- a/include/configs/mx28evk.h
>> +++ b/include/configs/mx28evk.h
>> @@ -290,6 +290,8 @@
>>       "uimage=uImage\0" \
>>       "console_fsl=ttyAM0\0" \
>>       "console_mainline=ttyAMA0\0" \
>> +     "ftd_file=imx28-evk.dtb\0" \
>> +     "ftd_addr=0x41000000\0" \
>>       "mmcdev=0\0" \
>>       "mmcpart=2\0" \
>>       "mmcroot=/dev/mmcblk0p3 rw rootwait\0" \
>> @@ -301,13 +303,22 @@
>>       "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
>>       "mmcboot=echo Booting from mmc ...; " \
>>               "run mmcargs; " \
>> -             "bootm\0" \
>> +             "if fatload mmc ${mmcdev}:${mmcpart} ${ftd_addr} ${ftd_file}; then " \
>> +                     "bootm ${loadaddr} - ${ftd_addr}; " \
>> +             "else " \
>> +                     "bootm; " \
>> +             "fi;\0" \
>>       "netargs=setenv bootargs console=${console_mainline},${baudrate} " \
>>               "root=/dev/nfs " \
>>               "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
>>       "netboot=echo Booting from net ...; " \
>>               "run netargs; " \
>> -             "dhcp ${uimage}; bootm\0"
>> +             "dhcp ${uimage}; " \
>> +             "if dhcp ${ftd_addr} ${ftd_file}; then " \
>> +                     "bootm ${loadaddr} - ${ftd_addr}; " \
>> +             "else " \
>> +                     "bootm; " \
>> +             "fi;\0"
>>
>>  #define CONFIG_BOOTCOMMAND \
>>       "mmc dev ${mmcdev}; if mmc rescan; then " \
>>
>
> Please fix the following warning reported by checkpatch:
>
> WARNING: line over 80 characters
> #39: FILE: include/configs/mx28evk.h:306:
> +               "if fatload mmc ${mmcdev}:${mmcpart} ${ftd_addr} ${ftd_file}; then " \
>
> total: 0 errors, 1 warnings, 32 lines checked

Some to the other patch; it is a little bit above the limit but it
seems more easy to read for me. I can fix it but I'd like to double
check before.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br