[U-Boot] [PATCH 1/8] net: ll_temac: Add LL TEMAC driver to u-boot

Michal Simek monstr at monstr.eu
Thu Feb 23 12:57:22 CET 2012


Stephan Linz wrote:
> Xilinx LocalLink Tri-Mode Ether MAC driver can be
> used by Xilinx Microblaze or Xilinx ppc405/440 in
> SDMA and FIFO mode. DCR or XPS bus can be used.
> 
> The driver uses and requires MII and PHYLIB.
> 
> CP: 4 warnings: 'Use of volatile is usually wrong'
> I won't fix this, because it depends on the network
> driver subsystem.
> 
> Reported-by: Michal Simek <monstr at monstr.eu>
> Signed-off-by: Stephan Linz <linz at li-pro.net>
> ---
>  drivers/net/Makefile               |    2 +
>  drivers/net/xilinx_ll_temac.c      |  433 ++++++++++++++++++++++++++++++++++++
>  drivers/net/xilinx_ll_temac_fifo.c |  143 ++++++++++++
>  drivers/net/xilinx_ll_temac_mdio.c |  180 +++++++++++++++
>  drivers/net/xilinx_ll_temac_sdma.c |  370 ++++++++++++++++++++++++++++++
>  include/netdev.h                   |    1 +
>  include/xilinx_ll_temac.h          |  358 +++++++++++++++++++++++++++++
>  include/xilinx_ll_temac_fifo.h     |  122 ++++++++++
>  include/xilinx_ll_temac_mdio.h     |   53 +++++
>  include/xilinx_ll_temac_sdma.h     |  281 +++++++++++++++++++++++
>  10 files changed, 1943 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/xilinx_ll_temac.c
>  create mode 100644 drivers/net/xilinx_ll_temac_fifo.c
>  create mode 100644 drivers/net/xilinx_ll_temac_mdio.c
>  create mode 100644 drivers/net/xilinx_ll_temac_sdma.c
>  create mode 100644 include/xilinx_ll_temac.h
>  create mode 100644 include/xilinx_ll_temac_fifo.h
>  create mode 100644 include/xilinx_ll_temac_mdio.h
>  create mode 100644 include/xilinx_ll_temac_sdma.h

I can't see the reason to add headers directly to include folder. It should be
fine to have them in drivers/net/ folder.

Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian


More information about the U-Boot mailing list