[U-Boot] [PATCH 01/14] Add AES crypto library

Marek Vasut marek.vasut at gmail.com
Sun Jan 8 09:57:47 CET 2012


> On Monday 26 December 2011 14:32:54 Simon Glass wrote:
> > --- /dev/null
> > +++ b/lib/aes.c
> > 
> > +static u8 sbox[256] = {
> > +static u8 inv_sbox[256] = {
> > +static u8 x2_sbox[256] = {
> > +static u8 x3_sbox[256] = {
> > +static u8 x_time_9[256] = {
> > +static u8 x_time_b[256] = {
> > +static u8 x_time_d[256] = {
> > +static u8 x_time_e[256] = {
> 
> const
> 
> > +static void mix_sub_columns(u8 *state)
> > +{
> > ...
> > +		 x3_sbox[state[2]] ^       sbox[state[7]];
> 
> looks bad whitespace after that ^
> 
> > +static u8 rcon[11] = {
> 
> const
> -mike

We already have checkpatch in tools ... run it on the series.

M


More information about the U-Boot mailing list