[U-Boot] [PATCH v4 0/4] mmc: Implement central card-detection.

Andy Fleming afleming at gmail.com
Mon Jan 9 04:47:11 CET 2012


On Mon, Jan 2, 2012 at 5:15 AM, Thierry Reding
<thierry.reding at avionic-design.de> wrote:
> This series of patches implements central card-detection within the MMC
> framework. Before this patch series, many boards actually did implement
> the board_mmc_getcd() function, but it wasn't used except by one driver
> (fsl_esdhc). Unfortunately, implementations interpreted the meaning of
> the cd parameter differently, some taking it to signal card absence and
> others using it to detect card presence. Furthermore, the signature of
> the board_mmc_getcd() function was not at all consistent with other MMC
> related functions.
>
> The first patch in this series therefore changes the board_mmc_getcd()
> function signature and consolidates all current implementations. The
> second patch adds a central card-detection implementation within the
> MMC framework by using the new board_mmc_getcd() function and adds a
> hook that can be provided by drivers to serve as a default card-detect
> mechanism if no board-specific implementation is provided. The third
> and fourth patches implement this driver hook for the fsl_esdhc and the
> tegra2 MMC drivers.
>
> For reference, the following email thread contains the discussion that
> led to this patch series:
>
>        http://lists.denx.de/pipermail/u-boot/2011-November/110180.html
>
> Changes in v4:
>  - rebase onto latest MMC tree as requested by Andy Fleming
>
> Changes in v3:
>  - reword subject line of patch 1 to be less confusing
>  - address coding style issues raised by Marek Vasut
>
> Changes in v2:
>  - add a better rationale for the series and a reference to the email
>    thread that started it
>  - add an explanation to patch 3 why the call to board_mmc_getcd() is
>    removed from the fsl_esdhc driver
>  - add a cover letter which explains the series' goal
>
> Thierry Reding (4):
>  mmc: Change board_mmc_getcd() function prototype.
>  mmc: Implement card detection.
>  mmc: fsl_esdhc: Implement card-detect hook.
>  mmc: tegra2: Implement card-detect hook.


Ooops.  It was this one I applied, not the v3 series. The v3 cover
letter thread ended up mingled with the v4 patches in my inbox.

Andy


More information about the U-Boot mailing list