[U-Boot] [PATCH] tegra: mmc: Support operation with dcache enabled

Simon Glass sjg at chromium.org
Mon Jan 9 06:31:45 CET 2012


Hi Andy,

On Sun, Jan 8, 2012 at 7:36 PM, Andy Fleming <afleming at gmail.com> wrote:
> On Wed, Dec 21, 2011 at 2:02 PM, Simon Glass <sjg at chromium.org> wrote:
>> When the data cache is enabled we must flush on write and invalidate
>> on read. We also check that buffers are aligned to data cache lines
>> boundaries. With recent work in U-Boot this should generally be the case
>> but the warnings will catch problems.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>H
> With this patch applied, I see these warnings:

Yes Tom mentioned this also. Since it seems this is the way we are
going (rather than a fix at the generic MMC level) I will tidy this up
and resubmit.

>
> tegra2_mmc.c: In function 'mmc_set_transfer_mode':
> tegra2_mmc.c:122:4: warning: passing argument 1 of
> 'flush_dcache_range' makes integer from pointer without a cast
> /local/afleming/u-boot/include/common.h:695:6: note: expected 'long
> unsigned int' but argument is of type 'const char *'
> tegra2_mmc.c:122:4: warning: passing argument 2 of
> 'flush_dcache_range' makes integer from pointer without a cast
> /local/afleming/u-boot/include/common.h:695:6: note: expected 'long
> unsigned int' but argument is of type 'const char *'
> tegra2_mmc.c: In function 'mmc_send_cmd':
> tegra2_mmc.c:326:5: warning: passing argument 1 of
> 'invalidate_dcache_range' makes integer from pointer without a cast
> /local/afleming/u-boot/include/common.h:696:6: note: expected 'long
> unsigned int' but argument is of type 'char *'
> tegra2_mmc.c:326:5: warning: passing argument 2 of
> 'invalidate_dcache_range' makes integer from pointer without a cast
> /local/afleming/u-boot/include/common.h:696:6: note: expected 'long
> unsigned int' but argument is of type 'char *'
>
> Andy

Regards,
Simon


More information about the U-Boot mailing list