[U-Boot] [RFC PATCH v2 03/28] arm: Only display frame buffer info if there is LCD/video support

[Albert ARIBAUD]

Hi Simon,

Le 07/01/2012 01:24, Simon Glass a écrit :
> This value has no meaning otherwise.
>
> Signed-off-by: Simon Glass<sjg at chromium.org>
> ---
>
>   common/cmd_bdinfo.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
> index ac8e78d..cdc595e 100644
> --- a/common/cmd_bdinfo.c
> +++ b/common/cmd_bdinfo.c
> @@ -369,7 +369,9 @@ int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>   	print_num("reloc off", gd->reloc_off);
>   	print_num("irq_sp", gd->irq_sp);	/* irq stack pointer */
>   	print_num("sp start ", gd->start_addr_sp);
> +#if defined(CONFIG_LCD) || defined(CONFIG_VIDEO)
>   	print_num("FB base  ", gd->fb_base);
> +#endif
>   	return 0;
>   }
>

I understand the field can have a meaningful value only for those boards 
with a display, but since it apparently exists on all boards, then it 
should be displayed -- or, if you feel it should not exist for boards 
without displays, then you should make its existence conditional as well.

Amicalement,
-- 
Albert.