[U-Boot] [PATCH 1/3] common: add possibility for readline_into_buffer timeout

[Mike Frysinger]

On Sunday 15 January 2012 02:53:40 Heiko Schocher wrote:
> --- a/common/main.c
> +++ b/common/main.c
>
> +		if ((first) && (timeout)) {

those inner parens make no sense

> +			ulong start = get_timer(0);
> +			ulong delay = timeout * CONFIG_SYS_HZ;

what do you want the timeout to be in ?  milliseconds ?  then make that part 
of the API (add comments to the relevant funcs), and drop the CONFIG_SYS_HZ 
usage.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120115/347da045/attachment.pgp>