[U-Boot] [PATCH v3 4/9] tegra: Add keyboard support to funcmux

[Stephen Warren]

On 01/16/2012 11:11 PM, Simon Glass wrote:
> Add funcmux support for the default keyboard mapping.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>

> diff --git a/arch/arm/cpu/armv7/tegra2/funcmux.c b/arch/arm/cpu/armv7/tegra2/funcmux.c

> +	case PERIPH_ID_KBC:
> +		if (config == FUNCMUX_DEFAULT) {
> +			enum pmux_pingrp grp[] = {PINGRP_KBCA, PINGRP_KBCB,
> +				PINGRP_KBCC, PINGRP_KBCD, PINGRP_KBCE,
> +				PINGRP_KBCF};
> +			int i;
> +
> +			for (i = 0; i < ARRAY_SIZE(grp); i++) {
> +				pinmux_tristate_disable(grp[i]);
> +				pinmux_set_func(grp[i], PMUX_FUNC_KBC);
> +				pinmux_set_pullupdown(grp[i], PMUX_PULL_UP);

Don't you only want to pull up the rows (or the columns) not both? I
guess it won't hurt to do both, but it's probably wasting power.

-- 
nvpublic