[U-Boot] [PATCH] tools/env: allow overwrite of ethaddr on default

Andreas Bießmann andreas.devel at googlemail.com
Mon Jan 23 13:23:09 CET 2012


Dear Wolfgang,

On 05.01.2012 16:59, Wolfgang Denk wrote:
> Dear Grant Erickson,
> 
> In message <1324580395-27004-1-git-send-email-marathon96 at gmail.com> you wrote:
>> This patch allows the U-Boot user space companion utility, fw_setenv,
>> to overwrite the 'ethaddr' key/value pair if the current value is set
>> to a per-board-configured default.
>>
>> This change allows 'fw_setenv' to match the behavior of 'setenv' /
>> 'env set' on the U-Boot command line.
>>
>> Signed-off-by: Grant Erickson <marathon96 at gmail.com>
>> ---
>>  tools/env/fw_env.c |   14 ++++++++++++--
>>  1 files changed, 12 insertions(+), 2 deletions(-)
> 
> Applied, thanks.

This patch breaks building 'env' without board configuration.
This is bad cause our automatic build environment build this tool for
different boards. Specific configuration is done via /etc/fw_env.config.
Can't we use some build-time configuration like
http://patchwork.ozlabs.org/patch/120372/ ?

best regards

Andreas Bießmann


More information about the U-Boot mailing list